Repository navigation
[release-branch.go1.27] Retry Darwin tests on fresh agents - #2717
Closed
Quim Muntal (qmuntal) wants to merge 1 commit into
Closed
Quim Muntal (qmuntal) wants to merge 1 commit into
Quim Muntal (qmuntal) wants to merge 1 commit into
Conversation
Backport of #2616. Retry failed Darwin test runs once on a fresh hosted agent, reusing the already-built toolchain, and publish per-attempt diagnostics and results. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The publish task lacks the targetPath and artifactName inputs needed to publish the staged toolchain, preventing a failed Darwin attempt from passing it to the fresh retry agent.
1 open issue
What changed in this PR
Backports fresh-agent Darwin test retries to the Go 1.27 servicing pipelines, reusing the built toolchain and preserving existing timeout scaling.
Changes:
- Limits eligible Darwin builders to an initial test run and one conditional fresh-agent retry.
- Extracts shared test steps with per-attempt results and diagnostic artifacts.
- Adds regression tests for retry gating, command arguments, exit handling, and toolchain archiving.
| File | Description |
|---|---|
| eng/pipeline/steps/run-builder-tests.yml | Shares test execution and per-attempt result publishing. |
| eng/pipeline/stages/run-stage.yml | Adds toolchain snapshots and a conditional fresh-agent retry job. |
| eng/pipeline/stages/builders-to-stages.yml | Enables fresh-agent retries for eligible Darwin builders. |
| eng/_util/cmd/pipelineymlgen/run_stage_test.go | Tests retry configuration, commands, and archive restoration. |
Review effort: Balanced
Comment on lines
+267
to
+269
| - task: ${{ iif(eq(variables['System.TeamProject'], 'public'), '', '1ES.') }}PublishPipelineArtifact@1 | ||
| displayName: Publish toolchain for test retry | ||
| condition: and(succeeded(), ne(variables['TEST_BUILDER_SUCCESSFUL'], 'true')) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Backport of #2616. This preserves the existing Go 1.27 Darwin/amd64 timeout scaling and adapts the retry plumbing to the servicing pipeline templates.
Validation
go test -mod=readonly -count=1 ./cmd/pipelineymlgen ./cmd/run-buildergo vet -mod=readonly ./cmd/run-buildergit diff --checkHosted Azure DevOps validation is pending.